[PATCH] D41693: [ARM][NFC] Avoid recreating MCSubtargetInfo in ARMAsmBackend
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 3 02:30:15 PST 2018
fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.
Great, thank you very much for cleaning that up Alex! It would be great if you could replace the string search for "thumb" with `isThumb()` before committing
================
Comment at: lib/Target/ARM/MCTargetDesc/ARMAsmBackend.h:28
+ : MCAsmBackend(), STI(STI),
+ isThumbMode(STI.getTargetTriple().getArchName().startswith("thumb")),
IsLittleEndian(IsLittle) {}
----------------
Could you use `STI.getTargetTriple().isThumb()` here?
https://reviews.llvm.org/D41693
More information about the llvm-commits
mailing list