[PATCH] D41619: [llvm-objcopy] Use physical instead of virtual address when aligning and placing sections in binary

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 2 14:43:02 PST 2018

jakehehrlich added a comment.

Other than the one inline comment I'm happy with this. I want James to take a look at this as well however. He's in England and will probably look at this tonight or the next day. I believe he had the same vacation days as me so he should be back as of tonight. I'd also really like someone with more embedded background to look at this but the evidence from BFD seems like an acceptable replacement.

Nice work.

Comment at: tools/llvm-objcopy/Object.cpp:896
+  bool HasAnyPAddr = false;
+  for (const auto &Segment: OrderedSegments) {
+    if (Segment->PAddr != 0) {
Can we use std::find_if and a lambda here instead?


More information about the llvm-commits mailing list