[PATCH] D41334: [CodeExtractor] Use function attributes from original function.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 2 14:07:17 PST 2018


efriedma added a comment.

You also can't copy readnone/readonly/writeonly/argmemonly/inaccessiblememonly/inaccessiblemem_or_argmemonly: the extracted code could read/modify an alloca allocated in the parent function.

allocsize also can't be copied for obvious reasons.  Same for returns_twice.

patchable-function doesn't make sense to copy; not sure it would do any harm, but doesn't do anything useful.  Same with alignstack.

Not sure about convergent.

And of course, there's a whole bunch of target-specific attributes, but hopefully those are all safe to copy.


https://reviews.llvm.org/D41334





More information about the llvm-commits mailing list