[PATCH] D41633: [InstCombine] Remove unneeded VarArg casts.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 2 13:49:37 PST 2018

fhahn abandoned this revision.
fhahn added a comment.

Happy new year and thank you very much for having a look!

If `ext_method` is a definition InstCombine already gets rid of the bitcast in the test case. It sounds like this is the best we can do. I'll abandon this review. But I think it would be worth to commit the test case (with an definition of `ext_method` instead of declare ) to the file, as this case seems not to be covered. Unless there are any objection, I'll do that as a NFC.


More information about the llvm-commits mailing list