[llvm] r321178 - [NVPTX] Initial adaptation of MCAsmStreamer/MCTargetStreamer for debug info in Cuda.

[Alexey Bataev via llvm-commits]

02.01.2018 12:35, David Blaikie пишет:
> +  if (MCTargetStreamer *TS = getTargetStreamer()) {
> +    TS->changeSection(getCurrentSectionOnly(), Section, Subsection, OS);
> +  } else {
> +    Section->PrintSwitchToSection(
> +        *MAI, getContext().getObjectFileInfo()->getTargetTriple(), OS,
> +        Subsection);
> +  }

> This ^ seems awkward. Is there any way to common these two codepaths?
(I see the default implementation of changeSection calls
PrintSwitchToSection, which should  make them common... except in this
case where MCAsmStreamer has no target streamer? When does that happen?)

Hi David,
I agree with you. But most of targets do not define their own
TargetStreamer. They don't need anything special in asm streamer. That's
why it is so weird.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180102/d18cbf9b/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180102/d18cbf9b/attachment-0001.sig>