[PATCH] D41402: [cmake] Fix DESTDIR support in compiler-rt build

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 2 11:10:32 PST 2018


smeenai added a comment.

@phosek over here (as in before this patch), `COMPILER_RT_INSTALL_PATH` is set to `CMAKE_INSTALL_PREFIX`, and then we have install commands like `install(... DESTINATION ${COMPILER_RT_INSTALL_PATH})`. Aren't those installation commands gonna fail for an empty `COMPILER_RT_INSTALL_PATH`? (I'm not setup to try a compiler-rt build right now, but I did reproduce that error in a test CMake project.)


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D41402





More information about the llvm-commits mailing list