[PATCH] D41633: [InstCombine] Remove unneeded VarArg casts.

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 2 10:39:37 PST 2018

rnk added a comment.

@rjmccall, does this cause problems on Darwin? I seem to recall that there are some ABIs (AArch64 Darwin) where arguments in the varargs pack are passed differently from the ones that are prototyped.

If that is a problem, do you think we can permit this simplification if we see a non-interposable definition of the callee? In this case, instcombine should "know" the true prototype of the callee and should be adjusting things so the types match.


More information about the llvm-commits mailing list