[PATCH] D41659: Implementing missing trigonometric optimizations

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstructionCombining.cpp:1431
+
+/// \brief Replaces the division or multiplication operations on trigonometric
+/// functions to equivalent trigonometric operation
----------------
Please remove the  \brief, it is redundant.


================
Comment at: lib/Transforms/InstCombine/InstructionCombining.cpp:1442
+
+      // return nullptr if argument to calls are not same
+      if (!(call1->getOperand(0) == call2->getOperand(0)))
----------------
Please always use full sentences in documentation:
`// Return nullptr if argument to calls are not same.`


Repository:
  rL LLVM

https://reviews.llvm.org/D41659