[PATCH] D41446: [TableGen][AsmMatcherEmitter] Generate assembler checks for tied operands

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 2 09:12:07 PST 2018


sdesmalen marked 11 inline comments as done.
sdesmalen added inline comments.


================
Comment at: utils/TableGen/AsmMatcherEmitter.cpp:914
+  const auto Pos =
+      std::find_if(std::begin(AsmOperands), std::end(AsmOperands),
+                   [&SymbolicName](const MatchableInfo::AsmOperand &A) {
----------------
fhahn wrote:
> Why not AsmOperands.begin(), AsmOperands.end()?
I can't answer the 'why', but I did fix it in the latest iteration of this patch :)


https://reviews.llvm.org/D41446





More information about the llvm-commits mailing list