[PATCH] D41609: NFC. Add description comments to Function header
Brian Rzycki via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 2 08:54:31 PST 2018
brzycki added a comment.
In https://reviews.llvm.org/D41609#965776, @Quolyk wrote:
> In https://reviews.llvm.org/D41609#964962, @brzycki wrote:
>
> > It looks ok to me. I’d prefer the comments reflect the overloaded method parameters but it’s not necessary.
>
>
> I've looked through other places with similar semantics, and it's quite common that comments do not reflect parameters type, so I decided to make it that way.
Sounds good to me. Adding documentation is always appreciated.
https://reviews.llvm.org/D41609
More information about the llvm-commits
mailing list