[PATCH] D41362: [AArch64][GlobalISel] Enable GlobalISel at -O0 by default

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 2 08:30:28 PST 2018

aemerson accepted this revision.
aemerson added inline comments.
This revision is now accepted and ready to land.

Comment at: test/CodeGen/AArch64/GlobalISel/arm64-fallback.ll:1
-; RUN: not llc -O0 -global-isel -verify-machineinstrs %s -o - 2>&1 | FileCheck %s --check-prefix=ERROR
+; RUN: not llc -O0 -global-isel -global-isel-abort=1 -verify-machineinstrs %s -o - 2>&1 | FileCheck %s --check-prefix=ERROR
 ; RUN: llc -O0 -global-isel -global-isel-abort=0 -verify-machineinstrs %s -o - 2>&1 | FileCheck %s --check-prefix=FALLBACK
aemerson wrote:
> Gerolf wrote:
> > Nit: -global-isel is no longer needed.
> Ack.
Actually is still needed since we're no longer aborting by default, while this specific test is checking that we fail on a specific input MIR so we need to trigger the error instead of falling back to SDAG.



More information about the llvm-commits mailing list