[PATCH] D41652: [InstCombine] Add an option to disable addrspacecast folding into GEP

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 2 05:50:19 PST 2018

davide requested changes to this revision.
davide added a comment.
This revision now requires changes to proceed.

I'm not sure having a `cl::opt` is the best option here.
If you really want to make such a change, can you at least thread this information through `TargetTransformInfo` rather than using a global option?
Also, for my own curiosity, is this a temporary workaround until AMDGPU grows proper support for 32-bit GEPs or is this an inherent limitation?
If the former, maybe this hack should not go in (or at least we should consider what's the amount of work needed to finish implementing the support)


More information about the llvm-commits mailing list