[PATCH] D41442: [AArch64][SVE] Asm: Add parsing of merging/zeroing suffix for SVE predicate vector operands

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 2 04:18:11 PST 2018

fhahn accepted this revision.
fhahn added reviewers: MatzeB, t.p.northover.
fhahn added subscribers: MatzeB, t.p.northover.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, `/` should only be valid for SVE predicates. I think it should be also fine for the Apple Asm variant, but I am adding  @MatzeB and @t.p.northover as reviewers in case I am missing something.

Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:2832
+  // Add zero/merge token.
+  const char *ZM = Pred == "z" ? "z" : "m";
+  Operands.push_back(
nit: No need for a variable here.


More information about the llvm-commits mailing list