[PATCH] D41362: [AArch64][GlobalISel] Enable GlobalISel at -O0 by default
Gerolf Hoflehner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 2 01:41:12 PST 2018
Gerolf added a comment.
I see all issues that came up in this thread covered by the last patch. Before this can be committed I still want to check that all paths/issues are tested/covered wrt to fast-isel:
a) how do we guarantee that there is no fallback from GISel to FastISel (when GISel is supported)? This is probably a nit since it is obvious to everyone deeper in the implementation then I am.
b) for all the tests where fast-isel was added shouldn't there equivalent tests for GISel, too? Even if the tests target fast-isel specific issues how do we make sure GISel does not expose similar/same bugs?
Comment at: test/CodeGen/AArch64/GlobalISel/arm64-fallback.ll:1
-; RUN: not llc -O0 -global-isel -verify-machineinstrs %s -o - 2>&1 | FileCheck %s --check-prefix=ERROR
+; RUN: not llc -O0 -global-isel -global-isel-abort=1 -verify-machineinstrs %s -o - 2>&1 | FileCheck %s --check-prefix=ERROR
; RUN: llc -O0 -global-isel -global-isel-abort=0 -verify-machineinstrs %s -o - 2>&1 | FileCheck %s --check-prefix=FALLBACK
Nit: -global-isel is no longer needed.
More information about the llvm-commits