[PATCH] D41644: Rename --icf-data and add a corresponding flag for functions

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 31 02:46:30 PST 2017


grimar added inline comments.


================
Comment at: ELF/Relocations.cpp:575
+
+  return false;
+}
----------------
Not a big deal but may be just

```
  return (Sym.isFunc() && Config->IgnoreFunctionAddressEquality) ||
         (Sym.isObject() && Config->IgnoreDataAddressEquality);
```


================
Comment at: test/ELF/protected-data-access.s:12
+
+# Check that we have a capy relocation.
+
----------------
capy -> copy


https://reviews.llvm.org/D41644





More information about the llvm-commits mailing list