[llvm] r321589 - Test fix after r321575

Robinson, Paul via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 30 14:19:37 PST 2017


Hi Philip,
One of our internal bots is still seeing the test fail even after
your fix.  Can you take another look at it?
Thanks,
--paulr


Command Output (stderr):
--
/home/siadmin/jenkins/w/opensource/opensource_build/llvm/test/CodeGen/AMDGPU/indirect-addressing-si.ll:478:11: error: expected string not found in input
; MOVREL: s_mov_b32 m0,
          ^
<stdin>:996:22: note: scanning from here
 buffer_load_dwordx4 v[0:3], off, s[0:3], 0
                     ^
<stdin>:1030:24: note: possible intended match here
; COMPUTE_PGM_RSRC2:TGID_Y_EN: 0



> -----Original Message-----
> From: llvm-commits [mailto:llvm-commits-bounces at lists.llvm.org] On Behalf
> Of Philip Reames via llvm-commits
> Sent: Saturday, December 30, 2017 10:43 AM
> To: llvm-commits at lists.llvm.org
> Subject: [llvm] r321589 - Test fix after r321575
> 
> Author: reames
> Date: Sat Dec 30 10:42:37 2017
> New Revision: 321589
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=321589&view=rev
> Log:
> Test fix after r321575
> 
> The test in question was checking for a particular intepretation of
> undefined behavior.  Relax the test to check that we simply don't crash.
> 
> Sorry for the breakage, I don't generally build AMDGPU locally and just
> saw the failure this morning.
> 
> 
> Modified:
>     llvm/trunk/test/CodeGen/AMDGPU/indirect-addressing-si.ll
> 
> Modified: llvm/trunk/test/CodeGen/AMDGPU/indirect-addressing-si.ll
> URL: http://llvm.org/viewvc/llvm-
> project/llvm/trunk/test/CodeGen/AMDGPU/indirect-addressing-
> si.ll?rev=321589&r1=321588&r2=321589&view=diff
> ==========================================================================
> ====
> --- llvm/trunk/test/CodeGen/AMDGPU/indirect-addressing-si.ll (original)
> +++ llvm/trunk/test/CodeGen/AMDGPU/indirect-addressing-si.ll Sat Dec 30
> 10:42:37 2017
> @@ -146,6 +146,7 @@ entry:
>  }
> 
>  ; GCN-LABEL: {{^}}extract_undef_offset_sgpr:
> +; undefined behavior, but shouldn't crash compiler
>  define amdgpu_kernel void @extract_undef_offset_sgpr(i32 addrspace(1)*
> %out, <4 x i32> addrspace(1)* %in) {
>  entry:
>    %ld = load volatile <4 x i32>, <4  x i32> addrspace(1)* %in
> @@ -155,9 +156,7 @@ entry:
>  }
> 
>  ; GCN-LABEL: {{^}}insert_undef_offset_sgpr_vector_src:
> -; GCN-DAG: buffer_load_dwordx4
> -; MOVREL-DAG: s_mov_b32 m0,
> -; MOVREL: v_movreld_b32
> +; undefined behavior, but shouldn't crash compiler
>  define amdgpu_kernel void @insert_undef_offset_sgpr_vector_src(<4 x i32>
> addrspace(1)* %out, <4 x i32> addrspace(1)* %in) {
>  entry:
>    %ld = load <4 x i32>, <4  x i32> addrspace(1)* %in
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list