[PATCH] D41632: [LLD] [COFF] Keep the underscore on exported decorated stdcall functions

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 29 12:30:19 PST 2017


mstorsjo created this revision.
mstorsjo added reviewers: ruiu, rnk, dmajor.

This (together with https://reviews.llvm.org/D41631) fixes PR35733.

I'm not very fond of adding yet another flag to signal this particular case, but I'm not sure if it'd be better to overload the existing fields Name/SymbolName/ExtName with extra interpretations for this particular case (I'm afraid that would break some other case where their differences actually matter).


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D41632

Files:
  COFF/Config.h
  COFF/Driver.cpp
  COFF/DriverUtils.cpp
  test/COFF/def-export-stdcall.s
  test/COFF/dllexport.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41632.128342.patch
Type: text/x-patch
Size: 4457 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171229/3601c08e/attachment.bin>


More information about the llvm-commits mailing list