[PATCH] D41381: [InstCombine] Missed optimization in math expression: squashing exp(log), log(exp)

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 29 07:17:28 PST 2017


hfinkel added a comment.

In https://reviews.llvm.org/D41381#965101, @spatel wrote:

> Since this hasn't been committed yet, let me ask: why are we doing this in instcombine rather than instsimplify? When no new instructions are created, we generally want that transform in InstSimplify because that makes passes like GVN more powerful. InstSimplify already has "SimplifyIntrinsic", so I think this could fit neatly in there.


Indeed, my oversight. Yes, it would be good to have this in InstSimplify.


https://reviews.llvm.org/D41381





More information about the llvm-commits mailing list