[PATCH] D41609: NFC. Add description comments to Function header

[Brian Rzycki via Phabricator via llvm-commits]

brzycki accepted this revision.
brzycki added a comment.
This revision is now accepted and ready to land.

It looks ok to me. I’d prefer the comments reflect the overloaded method parameters but it’s not necessary.



================
Comment at: include/llvm/IR/Function.h:267
+
+  /// @brief Return true if the function has the attribute.
   bool hasFnAttribute(StringRef Kind) const {
----------------
@Quolyk you might want to mention here this overloaded method uses a string reference to locate the function attribute.


================
Comment at: include/llvm/IR/Function.h:277
+
+  /// @brief Return the attribute for the given attribute kind.
   Attribute getFnAttribute(StringRef Kind) const {
----------------
Same as line 267.


================
Comment at: include/llvm/IR/Function.h:349
 
+  /// @brief gets the attribute from the list of attributes.
   Attribute getAttribute(unsigned i, StringRef Kind) const {
----------------
Same as line 267.


https://reviews.llvm.org/D41609