[PATCH] D41369: [PowerPC] Fix for PR35688 - handle out-of-range values for r+r to r+i conversion

Benjamin Kramer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 28 03:42:39 PST 2017


bkramer added a comment.

A test case for this edge case would be great.



================
Comment at: lib/Target/PowerPC/PPCInstrInfo.cpp:2461
+    // Set the bits (        MB + 32       ) to (        ME + 32       ).
+    uint64_t Mask = ((1LU << (32 - MB)) - 1) & ~((1LU << (31 - ME)) - 1);
     InVal &= Mask;
----------------
Use `LLU` instead of `LU`, otherwise it won't work on 32 bit platforms.


Repository:
  rL LLVM

https://reviews.llvm.org/D41369





More information about the llvm-commits mailing list