[PATCH] D41595: Incorrect operand sizes for some MMX instructions: punpcklwd, punpcklbw and punpckldq

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 27 15:02:45 PST 2017


craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86InstrMMX.td:112
   }
+  // MMXI_binop_rm32_int is like MMXI_binop_rm_int above but for mem32 input
+  multiclass MMXI_binop_rm32_int<bits<8> opc, string OpcodeStr, Intrinsic IntId,
----------------
Can we add a X86MemOperand parameter to MMXI_binop_rm_int that defaults to i64mem. Then just make MMXI_binop_rm32_int inherit from MMXI_binop_rm_int and pass the i32mem to that parameter.


https://reviews.llvm.org/D41595





More information about the llvm-commits mailing list