[PATCH] D41234: [ELF] Fix placement of a sentinel entry in the .ARM.exidx section.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/trunk/ELF/SyntheticSections.cpp:2573
+// The sentinel has to be removed if there are no other .ARM.exidx entries.
+bool ARMExidxSentinelSection::empty() const {
+  OutputSection *OS = getParent();
----------------
It looks like this function returns true if the parent section of this section is empty. That's different from what you'd expect for `empty`function. `empty` should return true if `this` is empty, not other object.


================
Comment at: lld/trunk/ELF/SyntheticSections.h:790
+
+  InputSection *Highest = 0;
 };
----------------
`= 0` is too C-ish. Please use nullptr. Also this needs comment because it is not obvious what this member is. What is Highest?


Repository:
  rL LLVM

https://reviews.llvm.org/D41234