[PATCH] D41590: Improve performance TokenizeWindowsCommandLine
    Rui Ueyama via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed Dec 27 00:11:07 PST 2017
    
    
  
ruiu added inline comments.
================
Comment at: llvm/lib/Support/CommandLine.cpp:725
+    if (isQuote(C)) {
+      char Quote = C;
+      ++I;
----------------
I'd remove this meaningless assignment -- you don't need to minimize the diff, but you want to make the code make sense as a whole for first-time readers.
https://reviews.llvm.org/D41590
    
    
More information about the llvm-commits
mailing list