[PATCH] D41590: Improve performance TokenizeWindowsCommandLine
Zachary Turner via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 26 23:33:04 PST 2017
On Tue, Dec 26, 2017 at 11:28 PM Rui Ueyama via Phabricator <
reviews at reviews.llvm.org> wrote:
> ruiu added inline comments.
>
>
> ================
> Comment at: llvm/lib/Support/CommandLine.cpp:692
> +static bool isWhitespace(char C) {
> + switch(C) {
> + case ' ':
> ----------------
> I'd ignore formfeed and vertical tab, and write like this
>
> return C == ' ' || C = '\t' || C = '\r' || C = '\n';
Why not just call std::isspace?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171227/f5881d9d/attachment.html>
More information about the llvm-commits
mailing list