[PATCH] D41576: [SCEV] Be careful with nuw/nsw/exact in InsertBinop

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.

lgtm!



================
Comment at: lib/Analysis/ScalarEvolutionExpander.cpp:204
       if (IP->getOpcode() == (unsigned)Opcode && IP->getOperand(0) == LHS &&
-          IP->getOperand(1) == RHS)
+          IP->getOperand(1) == RHS && !hasPoisonFlags(&*IP))
         return &*IP;
----------------
I also think s/hasPoisonFlags`/canGeneratePoison/ sounds better.


https://reviews.llvm.org/D41576