[PATCH] D41380: [SCEV] Do not insert if it is already in cache

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: lib/Analysis/ScalarEvolution.cpp:1272
+    if (const SCEV *S = UniqueSCEVs.FindNodeOrInsertPos(ID, IP))
+      return S;
   }
----------------
Please add comments here and below about what's going on.


================
Comment at: test/Analysis/ScalarEvolution/truncate.ll:22
+loop_second:                                           ; preds = %loop_second, %preheder_second
+  %1 = phi i64 [ %15, %preheder_second ], [ %4, %loop_second ]
+  %local_4_33 = phi i32 [ 3, %preheder_second ], [ %5, %loop_second ]
----------------
Please run this through `-metarenamer`.  The `%1` etc. names aren't really names, and e.g. adding a new instruction to the test will change these (which will make the test difficult to update).


https://reviews.llvm.org/D41380