[PATCH] D41578: [SCEV] Do not cache S -> V if S is not equivalent of V

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy added inline comments.


================
Comment at: lib/Analysis/ScalarEvolution.cpp:3773
+    if (isa<OverflowingBinaryOperator>(I))
+      if (auto *BS = dyn_cast<SCEVNAryExpr>(S)) {
+        if (I->hasNoSignedWrap() && !BS->hasNoSignedWrap())
----------------
skatkov wrote:
> sanjoy wrote:
> > Why `BS`?
> BinarySCEV ? :)
> 
> 
But it is n-ary SCEV (add / multiply expressions in SCEV can take an arbitrary number of operands).


https://reviews.llvm.org/D41578