[PATCH] D41581: [COFF] Do not parse args twice if no rsp files exists

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 26 21:09:19 PST 2017


ruiu added inline comments.


================
Comment at: lld/COFF/Driver.h:59-61
+  llvm::opt::InputArgList parseDirectives(StringRef S) {
+    return parseDirectives(tokenize(S));
+  }
----------------
Defining two functions for one feature doesn't make much sense. This forwarder function doesn't do anything other than calling tokenize(). Please move that piece of code to the other function and merge the two.


https://reviews.llvm.org/D41581





More information about the llvm-commits mailing list