[PATCH] D41581: [COFF] Do not parse args twice if no rsp files exists

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 26 19:10:32 PST 2017


ruiu added a comment.

Thank you for doing this.

A command line string and .drctive section contents is pretty different. The former may have response files, but the latter shouldn't. The performance of parsing a command line string is not important, so we can always parse the same command line twice.

I'd define a new function, ArgParser::parseDirectives next to ArgParser::parse to parse directives section contents. That should make code cleaner.


https://reviews.llvm.org/D41581





More information about the llvm-commits mailing list