[PATCH] D41524: [ELF] Only scan executables for shlib undefined symbols

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 26 10:18:34 PST 2017


Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:

> ruiu added a comment.
>
> LGTM, but please also fix scanShlibUndefined so that it doesn't automatically make symbols visible if they are referenced by DSOs. That seems like a root cause of the issue.

But that is the reason for having scanShlibUndefined, no? Exporting
symbols in a program if they are used in a shared libary.

Cheers,
Rafael


More information about the llvm-commits mailing list