[PATCH] D38313: [InstCombine] Introducing Aggressive Instruction Combine pass

[Amjad Aboud via Phabricator via llvm-commits]

aaboud added inline comments.


================
Comment at: test/Transforms/AggressiveInstCombine/trunc_multi_uses.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt < %s -aggressive-instcombine -S | FileCheck %s
----------------
zvi wrote:
> Should there be negative tests for the vector cases that are not permitted to transform?
There should be.
However, such tests needs instructions such as lshr, ashr, udiv or urem, i.e., instructions that increase the MinBitWidth that we can truncate the expression to.
So, I will add such test in the following patches, once I add support to these instructions.


https://reviews.llvm.org/D38313