[PATCH] D41477: [LLD] [ELF] Result of subtracting two symbols should be absolute

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 25 23:42:53 PST 2017


ruiu added inline comments.


================
Comment at: ELF/ScriptParser.cpp:153
 
 static ExprValue sub(ExprValue A, ExprValue B) {
+  if (!A.isAbsolute() && !B.isAbsolute())
----------------
Please add a comment saying that subtracting two symbol values should logically should yield an absolute value and that's actually what the bfd linker produces.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D41477





More information about the llvm-commits mailing list