[PATCH] D41551: [ELF] - Allow relocation to a weak undefined symbol when -z notext is given.

[Ed Maste via Phabricator via llvm-commits]

emaste added a comment.

This LGTM, I had a similar change in my repo while trying to fix PR35720.



================
Comment at: ELF/Relocations.cpp:607
+
   // Or, if we are allowed to create dynamic relocations against
   // read-only sections (i.e. when "-z notext" is given),
----------------
I think this comment was previously a logical continuation of the "is simply writable" comment, and the "Or," and ", too." don't quite really follow with the reordering, maybe just "If we are allowed ... a dynamic relocation as we want."


https://reviews.llvm.org/D41551