[PATCH] D41529: [llvm-readobj] Support -needed-libs option for COFF files

[Petr Hosek via Phabricator via llvm-commits]

phosek updated this revision to Diff 128066.
phosek added a comment.

Test added.


Repository:
  rL LLVM

https://reviews.llvm.org/D41529

Files:
  test/tools/llvm-readobj/Inputs/needed-libs.obj.coff-am64
  test/tools/llvm-readobj/coff-needed-libs.test
  tools/llvm-readobj/COFFDumper.cpp


Index: tools/llvm-readobj/COFFDumper.cpp
===================================================================
--- tools/llvm-readobj/COFFDumper.cpp
+++ tools/llvm-readobj/COFFDumper.cpp
@@ -81,6 +81,9 @@
   void printSymbols() override;
   void printDynamicSymbols() override;
   void printUnwindInfo() override;
+
+  void printNeededLibraries() override;
+
   void printCOFFImports() override;
   void printCOFFExports() override;
   void printCOFFDirectives() override;
@@ -1522,6 +1525,25 @@
   }
 }
 
+void COFFDumper::printNeededLibraries() {
+  ListScope D(W, "NeededLibraries");
+
+  using LibsTy = std::vector<StringRef>;
+  LibsTy Libs;
+
+  for (const ImportDirectoryEntryRef &DirRef : Obj->import_directories()) {
+    StringRef Name;
+    if (!DirRef.getName(Name))
+      Libs.push_back(Name);
+  }
+
+  std::stable_sort(Libs.begin(), Libs.end());
+
+  for (const auto &L : Libs) {
+    outs() << "  " << L << "\n";
+  }
+}
+
 void COFFDumper::printImportedSymbols(
     iterator_range<imported_symbol_iterator> Range) {
   for (const ImportedSymbolRef &I : Range) {
Index: test/tools/llvm-readobj/coff-needed-libs.test
===================================================================
--- /dev/null
+++ test/tools/llvm-readobj/coff-needed-libs.test
@@ -0,0 +1,5 @@
+RUN: llvm-readobj -needed-libs %p/Inputs/needed-libs.obj.coff-am64 | FileCheck %s
+
+CHECK:      NeededLibraries [
+CHECK-NEXT:   KERNEL32.dll
+CHECK-NEXT: ]


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41529.128066.patch
Type: text/x-patch
Size: 1439 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171223/a803a549/attachment.bin>