[PATCH] D38239: [ELF] - Define linkerscript symbols early.

[Rafael Avila de Espindola via llvm-commits]

George Rimar via Phabricator <reviews at reviews.llvm.org> writes:

> Index: ELF/Driver.cpp
> ===================================================================
> --- ELF/Driver.cpp
> +++ ELF/Driver.cpp
> @@ -1029,6 +1029,9 @@
>    for (StringRef Sym : Script->ReferencedSymbols)
>      Symtab->addUndefined<ELFT>(Sym);
>  
> +  // We want to declare linker script's symbols early, so that can version them.
> +  Script->declareSymbols();
> +
>    // Handle the `--undefined <sym>` options.
>    for (StringRef S : Config->Undefined)
>      Symtab->fetchIfLazy<ELFT>(S);

Do you need it this early? It should probably be after the fetchIfLazy
calls since those can add .o files, no?

Cheers,
Rafael