[PATCH] D41527: [llvm-readobj] Support -needed-libs option for Mach-O files

[Davide Italiano via Phabricator via llvm-commits]

davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.

LGTM with one comment addressed. Thanks.



================
Comment at: tools/llvm-readobj/MachODumper.cpp:701
+
+  std::stable_sort(Libs.begin(), Libs.end());
+
----------------
phosek wrote:
> davide wrote:
> > Why you need this stable sort?
> I have followed the ELF implementation which also uses stable sort, I'm not sure why it's used there.
I'd rather not cargo cult this here unless we have a good reason to. We shouldn't need this call, should we?


Repository:
  rL LLVM

https://reviews.llvm.org/D41527