[PATCH] D41206: [llvm-cov] Multi-threaded implementation of prepareFileReports method.

Max Moroz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 22 12:56:30 PST 2017


Dor1s added a comment.

Interesting. Actually, the new test seems to work fine, but bunch of others are failing with my change:

  Failing Tests (15):
      LLVM :: tools/llvm-cov/binary-formats.c
      LLVM :: tools/llvm-cov/dir-with-filtering.test
      LLVM :: tools/llvm-cov/load-multiple-objects.test
      LLVM :: tools/llvm-cov/multiple-files.test
      LLVM :: tools/llvm-cov/multiple-objects.test
      LLVM :: tools/llvm-cov/prevent_false_instantiations.h
      LLVM :: tools/llvm-cov/report.cpp
      LLVM :: tools/llvm-cov/showExpansions.cpp
      LLVM :: tools/llvm-cov/showHighlightedRanges.cpp
      LLVM :: tools/llvm-cov/showLineExecutionCounts.cpp
      LLVM :: tools/llvm-cov/showRegionMarkers.cpp
      LLVM :: tools/llvm-cov/showTemplateInstantiations.cpp
      LLVM :: tools/llvm-cov/sources-specified.test
      LLVM :: tools/llvm-cov/universal-binary.c
      LLVM :: tools/llvm-cov/zeroFunctionFile.c
  
    Expected Passes    : 21
    Unsupported Tests  : 1
    Unexpected Failures: 15

with the following crash:

  terminate called after throwing an instance of 'std::system_error'
    what():  Resource temporarily unavailable
  /usr/local/google/home/mmoroz/Projects/llvm/build/bin/llvm-cov[0x47e81a]
  /usr/local/google/home/mmoroz/Projects/llvm/build/bin/llvm-cov[0x47cb1e]
  /usr/local/google/home/mmoroz/Projects/llvm/build/bin/llvm-cov[0x47cc5a]
  /lib/x86_64-linux-gnu/libpthread.so.0(+0x10330)[0x7ff4e2fb5330]
  /lib/x86_64-linux-gnu/libc.so.6(gsignal+0x37)[0x7ff4e1fb0c37]
  /lib/x86_64-linux-gnu/libc.so.6(abort+0x148)[0x7ff4e1fb4028]
  /usr/lib/x86_64-linux-gnu/libstdc++.so.6(_ZN9__gnu_cxx27__verbose_terminate_handlerEv+0x155)[0x7ff4e28bf535]
  /usr/lib/x86_64-linux-gnu/libstdc++.so.6(+0x5e6d6)[0x7ff4e28bd6d6]
  /usr/lib/x86_64-linux-gnu/libstdc++.so.6(+0x5e703)[0x7ff4e28bd703]
  /usr/lib/x86_64-linux-gnu/libstdc++.so.6(+0x5e922)[0x7ff4e28bd922]
  /usr/lib/x86_64-linux-gnu/libstdc++.so.6(_ZSt20__throw_system_errori+0x80)[0x7ff4e290f800]
  /usr/lib/x86_64-linux-gnu/libstdc++.so.6(_ZNSt6thread15_M_start_threadESt10shared_ptrINS_10_Impl_baseEE+0x248)[0x7ff4e2910d68]
  /usr/local/google/home/mmoroz/Projects/llvm/build/bin/llvm-cov[0x461b55]
  /usr/local/google/home/mmoroz/Projects/llvm/build/bin/llvm-cov[0x434f16]
  /usr/local/google/home/mmoroz/Projects/llvm/build/bin/llvm-cov[0x435b37]
  /usr/local/google/home/mmoroz/Projects/llvm/build/bin/llvm-cov[0x4368d8]
  /usr/local/google/home/mmoroz/Projects/llvm/build/bin/llvm-cov[0x436aff]
  /usr/local/google/home/mmoroz/Projects/llvm/build/bin/llvm-cov[0x424c2b]
  /usr/local/google/home/mmoroz/Projects/llvm/build/bin/llvm-cov[0x42555b]
  /usr/local/google/home/mmoroz/Projects/llvm/build/bin/llvm-cov[0x40dd57]
  /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5)[0x7ff4e1f9bf45]
  /usr/local/google/home/mmoroz/Projects/llvm/build/bin/llvm-cov[0x412567]
  Stack dump:
  0.	Program arguments: /usr/local/google/home/mmoroz/Projects/llvm/build/bin/llvm-cov /usr/local/google/home/mmoroz/Projects/llvm/build/bin/llvm-cov report /usr/local/google/home/mmoroz/Projects/llvm/llvm/test/tools/llvm-cov/Inputs/report.covmapping -instr-profile /usr/local/google/home/mmoroz/Projects/llvm/llvm/test/tools/llvm-cov/Inputs/report.profdata -path-equivalence=/tmp,/usr/local/google/home/mmoroz/Projects/llvm/llvm/test/tools/llvm-cov -show-region-summary -show-instantiation-summary 
  Aborted (core dumped)

I've certainly broken something, will debug.


https://reviews.llvm.org/D41206





More information about the llvm-commits mailing list