[PATCH] D41541: [ELF] - Allow using PLT relocations when "-z notext" is given.

[Rafael Avila de Espindola via llvm-commits]

George Rimar via Phabricator <reviews at reviews.llvm.org> writes:
> Index: test/ELF/znotext-plt-relocations.s
> ===================================================================
> --- test/ELF/znotext-plt-relocations.s
> +++ test/ELF/znotext-plt-relocations.s
> @@ -0,0 +1,16 @@
> +# REQUIRES: x86
> +# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
> +# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %p/Inputs/znotext-plt-relocations.s -o %t2.o
> +# RUN: ld.lld %t2.o -o %t2.so -shared
> +# RUN: ld.lld -z notext %t.o %t2.so -o %t
> +# RUN: llvm-readobj -r %t | FileCheck %s
> +
> +# CHECK:      Relocations [
> +# CHECK-NEXT:   Section {{.*}} .rela.plt {
> +# CHECK-NEXT:     0x202018 R_X86_64_JUMP_SLOT atexit 0x0

Don't include the offset in the test.

> +# CHECK-NEXT:   }
> +# CHECK-NEXT: ]
> +
> +.text
> +_start:
> +callq atexit

Please add a ".quad foo" and define a foo function on the other file to
show how we handle both cases.

LGTM with that.

Thanks,
Rafael