[PATCH] D41489: [ThinLTO] Don't try to import noinline functions

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 22 06:41:12 PST 2017


tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM with one minor comment nit.
Thanks!



================
Comment at: lib/Analysis/ModuleSummaryAnalysis.cpp:310
+      F.isVarArg() ||
+      // Don't try to inline functions with noinline attribute.
+      F.getAttributes().hasFnAttribute(Attribute::NoInline);
----------------
s/inline functions/import functions/


https://reviews.llvm.org/D41489





More information about the llvm-commits mailing list