[PATCH] D41541: [ELF] - Allow using PLT relocations when "-z notext" is given.

Ed Maste via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 22 06:28:11 PST 2017


emaste added inline comments.


================
Comment at: ELF/Relocations.cpp:558
+static RelExpr getPltExpr(Symbol &Sym, RelExpr Expr, bool &IsConstant) {
+  // This handles a non PIC program call to function in a shared library. In
+  // an ideal world, we could just report an error saying the relocation can
----------------
Convention would have the comment before the function, no?


https://reviews.llvm.org/D41541





More information about the llvm-commits mailing list