[PATCH] D41519: [BasicBlockUtils] Check for unreachable preds before updating LI in UpdateAnalysisInformation

Anna Thomas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 22 04:59:02 PST 2017


anna added a comment.

In https://reviews.llvm.org/D41519#962880, @davide wrote:

> I think this is on the right track, but, can you please simplify the test case so I can read it better :) ?


Yes, absolutely agree. Actually, the testcase was a *manually simplified* version of bugpoint's output - bugpoint's simplified output had 230 lines in the testcase! 
Clearly, the manual simplification (75 lines) could still be improved :)

As an aside I think bugpoint needs improvement around invokes and landing blocks (unless there's some specific option to use here other than -compile-custom).


https://reviews.llvm.org/D41519





More information about the llvm-commits mailing list