[PATCH] D41540: [Support] Add WritableMemoryBuffer::getNewMemBuffer

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 22 03:41:59 PST 2017


labath created this revision.
labath added reviewers: dblaikie, Bigcheese.

The idea is that it would replace
(non-Writable)MemoryBuffer::getNewMemBuffer, which is quite useless
unless you const_cast its contents to write to it (which all (both)
callers of this function were doing). This patch also fixes one of the usages in
COFFWriter. After fixing the other usage in clang, I plan to delete the old
function.


https://reviews.llvm.org/D41540

Files:
  include/llvm/Support/MemoryBuffer.h
  lib/Object/WindowsResource.cpp
  lib/Support/MemoryBuffer.cpp
  unittests/Support/MemoryBufferTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41540.128008.patch
Type: text/x-patch
Size: 4678 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171222/004d65f4/attachment.bin>


More information about the llvm-commits mailing list