[PATCH] D41522: [Inliner] Restrict soft-float inlining penalty.

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 21 15:57:36 PST 2017


echristo added inline comments.


================
Comment at: lib/Analysis/InlineCost.cpp:1103
+    if (TTI.getFPOpCost(I.getType()) == TargetTransformInfo::TCC_Expensive ||
+        (F.getFnAttribute("use-soft-float").getValueAsString() == "true"))
+      Cost += InlineConstants::CallPenalty;
----------------
I realize you're just moving this code, but we might want to make this a TTI backend call for the function since there's also the subtarget feature on some targets as well.

Would it make since for this to be a part of getFPOpCost instead?


Repository:
  rL LLVM

https://reviews.llvm.org/D41522





More information about the llvm-commits mailing list