[PATCH] D41436: [X86][AVX512] Enable variable shuffle combining by default on AVX512 targets

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:28592
+  int VariableShuffleDepth =
+      Subtarget.hasFastVariableShuffle() || Subtarget.hasAVX512() ? 2 : 3;
   bool AllowVariableMask = (Depth >= VariableShuffleDepth) || HasVariableMask;
----------------
Should we just do the OR in the implementation of hasFastVariableShuffle()? That way if we use this method in other places they'll have consistent behavior.


Repository:
  rL LLVM

https://reviews.llvm.org/D41436