[llvm] r321273 - [mips] Fix the invalid EVA test

Simon Dardis via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 21 07:14:07 PST 2017


Author: sdardis
Date: Thu Dec 21 07:14:07 2017
New Revision: 321273

URL: http://llvm.org/viewvc/llvm-project?rev=321273&view=rev
Log:
[mips] Fix the invalid EVA test

During the review of D40362 I spotted that this test wasn't actually
testing the eva instructions due to '-mattr==eva', rather than '-mattr=+eva',
which resulted in test having no effect.

Modified:
    llvm/trunk/test/MC/Mips/eva/invalid.s

Modified: llvm/trunk/test/MC/Mips/eva/invalid.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/Mips/eva/invalid.s?rev=321273&r1=321272&r2=321273&view=diff
==============================================================================
--- llvm/trunk/test/MC/Mips/eva/invalid.s (original)
+++ llvm/trunk/test/MC/Mips/eva/invalid.s Thu Dec 21 07:14:07 2017
@@ -1,35 +1,36 @@
 # Instructions that are invalid
 #
 # RUN: not llvm-mc %s -triple=mips64-unknown-linux -show-encoding -mcpu=mips32r2 \
-# RUN:     -mattr==eva 2>%t1
+# RUN:     -mattr=+eva 2>%t1
 # RUN: FileCheck %s < %t1
 
     .set noat
-    cachee -1, 255($7) # CHECK: :[[@LINE]]:12: error: invalid operand for instruction
-    cachee 32, 255($7) # CHECK: :[[@LINE]]:12: error: invalid operand for instruction
-    prefe -1, 255($7)  # CHECK: :[[@LINE]]:11: error: invalid operand for instruction
-    prefe 32, 255($7)  # CHECK: :[[@LINE]]:11: error: invalid operand for instruction
+    cachee -1, 255($7) # CHECK: :[[@LINE]]:12: error: expected 5-bit unsigned immediate
+    cachee 32, 255($7) # CHECK: :[[@LINE]]:12: error: expected 5-bit unsigned immediate
+    prefe -1, 255($7)  # CHECK: :[[@LINE]]:11: error: expected 5-bit unsigned immediate
+    prefe 32, 255($7)  # CHECK: :[[@LINE]]:11: error: expected 5-bit unsigned immediate
     lle $33, 8($5)     # CHECK: :[[@LINE]]:9: error: invalid operand for instruction
-    lle $4, 8($33)     # CHECK: :[[@LINE]]:13: error: invalid operand for instruction
-    lle $4, 512($5)    # CHECK: :[[@LINE]]:13: error: invalid operand for instruction
-    lle $4, -513($5)   # CHECK: :[[@LINE]]:13: error: invalid operand for instruction
+    lle $4, 8($33)     # CHECK: :[[@LINE]]:13: error: expected memory with 9-bit signed offset
+    lle $4, 512($5)    # CHECK: :[[@LINE]]:13: error: expected memory with 9-bit signed offset
+    lle $4, -513($5)   # CHECK: :[[@LINE]]:13: error: expected memory with 9-bit signed offset
     lwe $33, 8($5)     # CHECK: :[[@LINE]]:9: error: invalid operand for instruction
-    lwe $4, 8($33)     # CHECK: :[[@LINE]]:13: error: invalid operand for instruction
-    lwe $4, 512($5)    # CHECK: :[[@LINE]]:13: error: invalid operand for instruction
-    lwe $4, -513($5)   # CHECK: :[[@LINE]]:13: error: invalid operand for instruction
+    lwe $4, 8($33)     # CHECK: :[[@LINE]]:13: error: expected memory with 9-bit signed offset
+    lwe $4, 512($5)    # CHECK: :[[@LINE]]:13: error: expected memory with 9-bit signed offset
+    lwe $4, -513($5)   # CHECK: :[[@LINE]]:13: error: expected memory with 9-bit signed offset
     sbe $33, 8($5)     # CHECK: :[[@LINE]]:9: error: invalid operand for instruction
-    sbe $4, 8($33)     # CHECK: :[[@LINE]]:13: error: invalid operand for instruction
-    sbe $4, 512($5)    # CHECK: :[[@LINE]]:13: error: invalid operand for instruction
-    sbe $4, -513($5)   # CHECK: :[[@LINE]]:13: error: invalid operand for instruction
+    sbe $4, 8($33)     # CHECK: :[[@LINE]]:13: error: expected memory with 9-bit signed offset
+    sbe $4, 512($5)    # CHECK: :[[@LINE]]:13: error: expected memory with 9-bit signed offset
+    sbe $4, -513($5)   # CHECK: :[[@LINE]]:13: error: expected memory with 9-bit signed offset
     sce $33, 8($5)     # CHECK: :[[@LINE]]:9: error: invalid operand for instruction
-    sce $4, 8($33)     # CHECK: :[[@LINE]]:13: error: invalid operand for instruction
-    sce $4, 512($5)    # CHECK: :[[@LINE]]:13: error: invalid operand for instruction
-    sce $4, -513($5)   # CHECK: :[[@LINE]]:13: error: invalid operand for instruction
+    sce $4, 8($33)     # CHECK: :[[@LINE]]:13: error: expected memory with 9-bit signed offset
+    sce $4, 512($5)    # CHECK: :[[@LINE]]:13: error: expected memory with 9-bit signed offset
+    sce $4, -513($5)   # CHECK: :[[@LINE]]:13: error: expected memory with 9-bit signed offset
     she $33, 8($5)     # CHECK: :[[@LINE]]:9: error: invalid operand for instruction
-    she $4, 8($33)     # CHECK: :[[@LINE]]:13: error: invalid operand for instruction
-    she $4, 512($5)    # CHECK: :[[@LINE]]:13: error: invalid operand for instruction
-    she $4, -513($5)   # CHECK: :[[@LINE]]:13: error: invalid operand for instruction
+    she $4, 8($33)     # CHECK: :[[@LINE]]:13: error: expected memory with 9-bit signed offset
+    she $4, 512($5)    # CHECK: :[[@LINE]]:13: error: expected memory with 9-bit signed offset
+    she $4, -513($5)   # CHECK: :[[@LINE]]:13: error: expected memory with 9-bit signed offset
     swe $33, 8($4)     # CHECK: :[[@LINE]]:9: error: invalid operand for instruction
-    swe $5, 8($34)     # CHECK: :[[@LINE]]:13: error: invalid operand for instruction
-    swe $5, 512($4)    # CHECK: :[[@LINE]]:13: error: invalid operand for instruction
-    swe $5, -513($4)   # CHECK: :[[@LINE]]:13: error: invalid operand for instruction
+    swe $5, 8($34)     # CHECK: :[[@LINE]]:13: error: expected memory with 9-bit signed offset
+    swe $5, 512($4)    # CHECK: :[[@LINE]]:13: error: expected memory with 9-bit signed offset
+    swe $5, -513($4)   # CHECK: :[[@LINE]]:13: error: expected memory with 9-bit signed offset
+




More information about the llvm-commits mailing list