[PATCH] D41362: [AArch64][GlobalISel] Enable GlobalISel at -O0 by default

[Daniel Sanders via Phabricator via llvm-commits]

dsanders added a comment.

In https://reviews.llvm.org/D41362#961783, @qcolombet wrote:

> > How about checking for EnableGlobalISelAbort.getNumOccurences() > 0 to check for an command line override, otherwise doing what the target wants via the isGlobalISelAbortEnabled() override?
>
> That's what I meant :). (Instead of adding a `== 3` case for the option.)


I'd be surprised if an API user want to force aborts to be enabled so it makes sense to me to check the number of occurrences of the command line option.

One possible spelling nit: If we want a target hook to control this, shouldn't the hook describe a property of the target rather than a property of the GlobalISel implementation? I'm thinking along the lines of CompleteModel in the scheduler to get something like isGlobalISelComplete() or useGlobalISelOnly()


Repository:
  rL LLVM

https://reviews.llvm.org/D41362