[PATCH] D41459: [lld] Fix output section offset and contents when linker script uses memory region and data commands

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

You need to add reviewers when posting the patches. It is at least Rui as code owner of LLD.
Logic of patch looks correct for me. I'll add him.



================
Comment at: ELF/LinkerScript.cpp:696
       Dot += Cmd->Size;
+      if (Ctx->MemRegion){
+        Ctx->MemRegionOffset[Ctx->MemRegion] += Cmd->Size;
----------------
You do not need bracers around single line.


================
Comment at: test/ELF/linkerscript/data-commands.s:47
 
+# RUN: echo "MEMORY                  \
+# RUN:   {                           \
----------------
```
MEMORY {
```


================
Comment at: test/ELF/linkerscript/data-commands.s:51
+# RUN:   }                           \
+# RUN:  SECTIONS                     \
+# RUN:  {                            \
----------------
```
SECTIONS {
```


https://reviews.llvm.org/D41459