[compiler-rt] r321232 - [ubsan] Diagnose noreturn functions which return (compiler-rt)

[Vedant Kumar via llvm-commits]

Author: vedantk
Date: Wed Dec 20 16:10:36 2017
New Revision: 321232

URL: http://llvm.org/viewvc/llvm-project?rev=321232&view=rev
Log:
[ubsan] Diagnose noreturn functions which return (compiler-rt)

This is paired with the clang change: https://reviews.llvm.org/D40698

Differential Revision: https://reviews.llvm.org/D40700

Added:
    compiler-rt/trunk/test/ubsan/TestCases/Misc/Inputs/returns-unexpectedly.c
Modified:
    compiler-rt/trunk/lib/ubsan/ubsan_handlers.cc
    compiler-rt/trunk/test/ubsan/TestCases/Misc/unreachable.cpp

Modified: compiler-rt/trunk/lib/ubsan/ubsan_handlers.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/ubsan/ubsan_handlers.cc?rev=321232&r1=321231&r2=321232&view=diff
==============================================================================
--- compiler-rt/trunk/lib/ubsan/ubsan_handlers.cc (original)
+++ compiler-rt/trunk/lib/ubsan/ubsan_handlers.cc Wed Dec 20 16:10:36 2017
@@ -297,7 +297,7 @@ void __ubsan::__ubsan_handle_out_of_boun
 static void handleBuiltinUnreachableImpl(UnreachableData *Data,
                                          ReportOptions Opts) {
   ScopedReport R(Opts, Data->Loc, ErrorType::UnreachableCall);
-  Diag(Data->Loc, DL_Error, "execution reached a __builtin_unreachable() call");
+  Diag(Data->Loc, DL_Error, "execution reached an unreachable program point");
 }
 
 void __ubsan::__ubsan_handle_builtin_unreachable(UnreachableData *Data) {

Added: compiler-rt/trunk/test/ubsan/TestCases/Misc/Inputs/returns-unexpectedly.c
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/ubsan/TestCases/Misc/Inputs/returns-unexpectedly.c?rev=321232&view=auto
==============================================================================
--- compiler-rt/trunk/test/ubsan/TestCases/Misc/Inputs/returns-unexpectedly.c (added)
+++ compiler-rt/trunk/test/ubsan/TestCases/Misc/Inputs/returns-unexpectedly.c Wed Dec 20 16:10:36 2017
@@ -0,0 +1 @@
+void returns_unexpectedly() {}

Modified: compiler-rt/trunk/test/ubsan/TestCases/Misc/unreachable.cpp
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/ubsan/TestCases/Misc/unreachable.cpp?rev=321232&r1=321231&r2=321232&view=diff
==============================================================================
--- compiler-rt/trunk/test/ubsan/TestCases/Misc/unreachable.cpp (original)
+++ compiler-rt/trunk/test/ubsan/TestCases/Misc/unreachable.cpp Wed Dec 20 16:10:36 2017
@@ -1,6 +1,25 @@
-// RUN: %clangxx -fsanitize=unreachable %s -O3 -o %t && not %run %t 2>&1 | FileCheck %s
+// RUN: %clang %S/Inputs/returns-unexpectedly.c -O3 -c -o %t.ru.o
+// RUN: %clangxx -fsanitize=unreachable -O3 -o %t %s %t.ru.o
+// RUN: not %run %t builtin 2>&1 | FileCheck %s -check-prefix=BUILTIN
+// RUN: not %run %t noreturn-callee-marked 2>&1 | FileCheck %s -check-prefix=NORETURN1
+// RUN: not %run %t noreturn-caller-marked 2>&1 | FileCheck %s -check-prefix=NORETURN2
+
+#include <string.h>
+
+void __attribute__((noreturn)) callee_marked_noreturn() {
+  // NORETURN1: unreachable.cpp:[[@LINE+1]]:1: runtime error: execution reached an unreachable program point
+}
+
+extern "C" void __attribute__((noreturn)) returns_unexpectedly();
 
 int main(int, char **argv) {
-  // CHECK: unreachable.cpp:5:3: runtime error: execution reached a __builtin_unreachable() call
-  __builtin_unreachable();
+  if (strcmp(argv[1], "builtin") == 0)
+    // BUILTIN: unreachable.cpp:[[@LINE+1]]:5: runtime error: execution reached an unreachable program point
+    __builtin_unreachable();
+  else if (strcmp(argv[1], "noreturn-callee-marked") == 0)
+    callee_marked_noreturn();
+  else if (strcmp(argv[1], "noreturn-caller-marked") == 0)
+    // NORETURN2: unreachable.cpp:[[@LINE+1]]:5: runtime error: execution reached an unreachable program point
+    returns_unexpectedly();
+  return 0;
 }