[PATCH] D41361: [SimplifyCFG] Avoid quadratic on a predecessors number behavior in instruction sinking.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 20 15:04:29 PST 2017


efriedma added a comment.

The change to arm64-jumptable.ll looks fine.  I think something is going wrong in avoid-cpsr-rmw.ll.

> Since we're not changing logic for generating selects and we're ending up with them now, I assume that it's also a desirable form of IR in this case.

We have thresholds in various places to avoid transforming control flow into straight-line computation if it gets too expensive; they're scattered all over the place, though, so we might not handle it consistently.


https://reviews.llvm.org/D41361





More information about the llvm-commits mailing list