[PATCH] D41146: [DWARF] DWARF v5: Rework of string offsets table reader

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp updated this revision to Diff 127764.
wolfgangp marked 5 inline comments as done.
wolfgangp added a comment.

Refactored the string offsets contribution descriptor using Optional<>, which removes the need for a "valid" bit. Addressed some other review comments.


https://reviews.llvm.org/D41146

Files:
  include/llvm/DebugInfo/DWARF/DWARFUnit.h
  lib/DebugInfo/DWARF/DWARFContext.cpp
  lib/DebugInfo/DWARF/DWARFUnit.cpp
  test/DebugInfo/X86/dwarfdump-str-offsets-dwp.s
  test/DebugInfo/X86/dwarfdump-str-offsets-invalid-3.s
  test/DebugInfo/X86/dwarfdump-str-offsets-invalid-4.s
  test/DebugInfo/X86/dwarfdump-str-offsets-invalid-6.s
  test/DebugInfo/X86/dwarfdump-str-offsets-macho.s
  test/DebugInfo/X86/dwarfdump-str-offsets.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41146.127764.patch
Type: text/x-patch
Size: 53602 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171220/4c040a4d/attachment.bin>